added custom annotation to ingress for CORS #3004
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
support CORS by providing a custom annotation to Ingress', which then is reflected in the NGINX ingress configuration.
By adding the custom annotation "custom.nginx.org/cors-allow-origin" to an ingress, with the value of the target server (i.e. "https://sample.server.org/"), the according NGINX ingress configuration is created in the "server {}" section:
Hiding the original header values proved to be required, as else the browser might complain about multiple set values.
Checklist
Before creating a PR, run through this checklist and mark each as complete.