-
Notifications
You must be signed in to change notification settings - Fork 2k
Update the ConfigMap Zone Sync documentation #7681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the ConfigMap Zone Sync documentation by changing the order and formatting of some information. Previously, all of the content was in a note call-out after the table of keys and descriptions. Now, the important information about TLS availability is part of the main text, and the note call-out for a possible error is instead a caution call-out just before the table. Previously, there was a somewhat redundant (And broken) link. The frontmatter data of the page has also been updated.
✅ Deploy Preview will be available once build job completes!
|
danielnginx
previously approved these changes
Apr 18, 2025
AlexFenlon
previously approved these changes
Apr 22, 2025
ADubhlaoich
commented
Apr 22, 2025
site/content/configuration/global-configuration/configmap-resource.md
Outdated
Show resolved
Hide resolved
…urce.md Signed-off-by: Alan Dooley <[email protected]>
6815489
Had to re-request reviews after removing some empty lines. Auto-merge enabled. |
y82
approved these changes
Apr 22, 2025
AlexFenlon
approved these changes
Apr 22, 2025
nginx-bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
This commit updates the ConfigMap Zone Sync documentation by changing the order and formatting of some information. Previously, all of the content was in a note call-out after the table of keys and descriptions. Now, the important information about TLS availability is part of the main text, and the note call-out for a possible error is instead a caution call-out just before the table. Previously, there was a somewhat redundant (And broken) link. The frontmatter data of the page has also been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
needs cherry pick
Cherry pick this PR into a release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit updates the ConfigMap Zone Sync documentation by changing the order and formatting of some information. Previously, all of the content was in a note call-out after the table of keys and descriptions.
Now, the important information about TLS availability is part of the main text, and the note call-out for a possible error is instead a caution call-out just before the table.
Previously, there was a somewhat redundant (And broken) link. The frontmatter data of the page has also been updated.
Checklist
Before creating a PR, run through this checklist and mark each as complete.