Skip to content

CP/DP Split: Add ability to set loadBalancerClass for load balancer Service #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: change/control-data-plane-split
Choose a base branch
from

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Apr 23, 2025

Proposed changes

Add ability to set loadBalancerClass for load balancer Service

Problem: We would like the ability to specify the loadBalanacerClass field on a load balancer service.

Solution: Add ability to set loadBalancerClass for load balancer Service.

Testing: Manually tested that deploying NGF with the nginx.service.loadBalancerClass Helm flag would correctly set the field. Also tested that modifying the NginxProxy resource would set the loadBalancerClass when the service was re-created (the field can only be set upon creation).

Closes #3303

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@bjee19 bjee19 requested a review from a team as a code owner April 23, 2025 19:36
@github-actions github-actions bot added enhancement New feature or request helm-chart Relates to helm chart labels Apr 23, 2025
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (5084be8) to head (92219d5).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #3319      +/-   ##
===================================================================
- Coverage                            86.77%   86.74%   -0.04%     
===================================================================
  Files                                  128      128              
  Lines                                14712    14715       +3     
  Branches                                62       62              
===================================================================
- Hits                                 12766    12764       -2     
- Misses                                1806     1810       +4     
- Partials                               140      141       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm-chart Relates to helm chart
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants