This repository was archived by the owner on May 24, 2023. It is now read-only.
Update Dockerfile and CI #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucacome
commented
Jan 11, 2022
lucacome
commented
- Updates CI to use metadata action
- Updates Dockerfile to always use UBI as the base image, removing additional Dockerfile
lucacome
requested review from
ciarams87 and
soneillf5
and removed request for
a team
lucacome
force-pushed
the
chore/docker-changes
branch
from
fd22580 to
66f199a
Compare
ciarams87
reviewed
Jan 11, 2022
ciarams87
reviewed
Jan 11, 2022
| @@ -43,7 +43,6 @@ ENVTEST_K8S_VERSION = 1.22 | |||
|
|
|||
| # Change DOCKERFILE tp openshift.Dockerfile to build Openshift image | |||
| DOCKERFILE ?= Dockerfile | |||
| RH_RBAC_IMAGE ?= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.7 | |||
There was a problem hiding this comment.
So handy that we don't have to update to this image any more 🎉
ciarams87
approved these changes
Jan 11, 2022
pleshakov
approved these changes
Jan 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.