This repository was archived by the owner on May 24, 2023. It is now read-only.
Release 0.1.0 #72
Merged
Release 0.1.0 #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
force-pushed
the
r-0.1.0
branch
2 times, most recently
from
f8c7023 to
dd6d115
Compare
Dean-Coakley
commented
Mar 5, 2021
bundle/0.1.0/manifests/nginx-ingress-operator.v0.1.0.clusterserviceversion.yaml
Show resolved
Hide resolved
ciarams87
reviewed
Mar 5, 2021
pleshakov
reviewed
Mar 5, 2021
pleshakov
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
@Dean-Coakley
looks good to me.
however, I added a suggestion to extend the upgrade instructions to make sure it covers the secrets fully (the actions from #39 )
vepatel
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.