Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

Update go to 1.14 #8

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Update go to 1.14 #8

merged 2 commits into from
Apr 24, 2020

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Update go from 1.13 to 1.14

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Apr 24, 2020
@Dean-Coakley Dean-Coakley requested a review from Rulox April 24, 2020 13:43
@Dean-Coakley Dean-Coakley self-assigned this Apr 24, 2020
@Dean-Coakley
Copy link
Contributor Author

@Rulox Should I also bump?: https://github.com/nginxinc/nginx-ingress-operator/blob/master/docs/manual-installation.md#prerequisites

I decided to leave it as it was tested as working in go 1.13. - But I guess that'll change in the next version.

Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good, >= 1.13 should work. Thanks!

@Dean-Coakley Dean-Coakley merged commit cd62b30 into master Apr 24, 2020
@Dean-Coakley Dean-Coakley deleted the update-go branch April 24, 2020 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants