Skip to content

NH-3670 - Dynamic component should allow generic dictionary #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nhibernate-bot opened this issue Oct 12, 2017 · 0 comments
Closed

NH-3670 - Dynamic component should allow generic dictionary #755

nhibernate-bot opened this issue Oct 12, 2017 · 0 comments
Labels
c: Core migrated p: Lowest possible breaking change r: Fixed t: Improvement
Milestone
5.2

Comments

@nhibernate-bot
Copy link
Collaborator

nhibernate-bot commented Oct 12, 2017 •
edited by fredericDelaporte
Loading

Ricardo Peres created an issue — 19th August 2014, 15:11:42:

Currently, the <dynamic-component> mapping only allows properties of type IDictionary. It should also support IDictionary<string, object>.

Ricardo Peres added a comment — 20th August 2014, 10:40:44:

Pull request: #305
Created additional generic (with IDictionary<string, object>) tests for all test cases related to dynamic-component (NH-1796, NH-1039, NH-3571 and NH-2664)

Possible breaking change: mapping a dynamic component with a Hashtable property instead of an IDictionary as documented is no more supported.
@hazzik hazzik added this to the 5.2 milestone Jun 6, 2018
@hazzik hazzik changed the title NH-3670 - Dynamic Component Should Allow Generic Dictionary NH-3670 - Dynamic component should allow generic dictionary Jun 6, 2018
hazzik added a commit to hazzik/nhibernate-core that referenced this issue Jun 6, 2018
@hazzik
Do something useful in the test
bab942a 
While nhibernate#755 is not fixed we have to use IDictionary as a dynamic component property type
@hazzik hazzik mentioned this issue Jun 6, 2018
Closed
@hazzik hazzik closed this as completed in dc71c7d Jun 7, 2018
@rjperes rjperes mentioned this issue Jun 21, 2018
Merged
fredericDelaporte added a commit to fredericDelaporte/nhibernate-core that referenced this issue Jun 21, 2018
@fredericDelaporte
Allow generic dictionaries for dynamic entities
3b3504c 
Follow-up to nhibernate#755
@fredericDelaporte fredericDelaporte mentioned this issue Jun 21, 2018
Merged
fredericDelaporte added a commit that referenced this issue Jun 25, 2018
@fredericDelaporte
Allow generic dictionaries for dynamic entities (#1767)
af319b6 
Follow-up to #755
@fredericDelaporte fredericDelaporte mentioned this issue Mar 12, 2019
Closed
grifsun added a commit to grifsun/fluent-nhibernate that referenced this issue Mar 19, 2021
@grifsun
Add support mapping generic DynamicComponent (nhibernate/nhibernate-c…
b71f448 
…ore#755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Core migrated p: Lowest possible breaking change r: Fixed t: Improvement
Projects
None yet
Milestone
5.2
Development

No branches or pull requests
3 participants
@hazzik @fredericDelaporte @nhibernate-bot