Skip to content

Fix nullable entity comparison with null #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2021

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Aug 9, 2021

Fixes #2611

@fredericDelaporte

This comment has been minimized.

@fredericDelaporte fredericDelaporte added this to the 5.3.10 milestone Aug 9, 2021
@bahusoid

This comment has been minimized.

@hazzik
Copy link
Member

hazzik commented Aug 9, 2021

Do I understand correctly that the correct SQL would be like this?

select * from Parent p left join OneToOne  o on p.Id = o.Id where o.Id is null

@bahusoid
Copy link
Member Author

Yes. Left join is needed instead of implicit

@hazzik
Copy link
Member

hazzik commented Aug 10, 2021

image

I made it working. Need to resolve TODO. Feel free to drop the commit if you don't like it.

@bahusoid
Copy link
Member Author

I made it working.

I made similar changes in #2612. Only then I tried to make it more general fix not bound to is null comparison. Yeah I also realized that merging both PRs might be a good idea..

@bahusoid bahusoid changed the title Restore 5.2.x behavior for nullable entity null check Fix nullable entity comparison with null Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants