Add GetOrBuild on the session factory factory #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
force-pushed
the
fixes/sess-fact-fact-thr-gh3657
branch
from
1015c2a to
d36824c
Compare
| /// built, which may lead to threading issues.</para> | ||
| /// </remarks> | ||
| [MethodImpl(MethodImplOptions.Synchronized)] | ||
| public static ISessionFactory GetOrBuildNamedInstance(string name, Func<ISessionFactory> instanceBuilder) |
There was a problem hiding this comment.
To allow threadsafe use of the factory, a get or build is needed. Some applications do use it in a multi-thread context. They were always exposed to threading bugs due to the get being able of yielding a not yet fully built instance in such case, but this was worsen by #2190. With this GetOrBuild, provided the application only build factories through it, fully built instances will be yielded.
fredericDelaporte
changed the title
fredericDelaporte
force-pushed
the
fixes/sess-fact-fact-thr-gh3657
branch
from
d36824c to
5c1a9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3657