spring-projectsgh-291

nhomble · nhomble · commit 2e318ad60456 · 2019-12-17T22:22:31.000-05:00
More descriptive error message by including offending group name
diff --git a/spring-shell-core/src/main/java/org/springframework/shell/Command.java b/spring-shell-core/src/main/java/org/springframework/shell/Command.java
@@ -46,9 +46,9 @@ public Help(String description) {
 		}
 
 		public Help(String description, String group) {
-			Assert.isTrue(StringUtils.hasText(description), "Command description cannot be null or empty");
-			this.description = description;
 			this.group = StringUtils.hasText(group) ? group : "";
+			Assert.isTrue(StringUtils.hasText(description), "Command description cannot be null or empty group='" + this.group + "'");
+			this.description = description;
 		}
 
 		public String getDescription() {

Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,9 @@ public Help(String description) {`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`public Help(String description, String group) {`
`49`		`- Assert.isTrue(StringUtils.hasText(description), "Command description cannot be null or empty");`
`50`		`- this.description = description;`
`51`	`49`	`this.group = StringUtils.hasText(group) ? group : "";`
	`50`	`+ Assert.isTrue(StringUtils.hasText(description), "Command description cannot be null or empty group='" + this.group + "'");`
	`51`	`+ this.description = description;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`public String getDescription() {`