Skip to content

Include group name in Command.java assertions #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhomble opened this issue Dec 18, 2019 · 1 comment
Closed

Include group name in Command.java assertions #291

nhomble opened this issue Dec 18, 2019 · 1 comment

Comments

@nhomble
Copy link
Contributor

nhomble commented Dec 18, 2019

The application failed to start up because of Assertions in Command. Specifically, I was hit by Help constructor which asserts that description has text. I think the assertion is great, but I had to put debug points to finally figure out which class had the offender. Since group is usually defined (since we default to the class name when a name isn't explicitly defined) in StandardMethodTargetRegistrar::getOrInferGroup I think we could just add this to the assertion message for clarity?

nhomble added a commit to nhomble/spring-shell that referenced this issue Dec 18, 2019
More descriptive error message by including offending group name
@jvalkeal
Copy link
Contributor

We're doing housekeeping in issues and closing ones which are potentially stale due to recent changes in a project. We are now more up to date with Spring Boot starting with release 2.1.0 and work in 3.x making shell compatible with Spring Framework 6 and Spring Boot 3.

If you think issue should not have been closed, try to re-open or open a new issue with updated info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants