add macOS special case #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the released file have changed from 3.1.1 onward. I simply added a if else statement. I didn't know which synthaxe you would prefer. I also don't know which version I should used between arm64 and x86_64, I'm happy to change if you think it's useful.
|
Thanks! |
|
Note that I didn't had the chance to test it ! |
|
@nikeee, I tested the new one in the following pipeline: https://github.com/pydata/pydata-sphinx-theme/actions/runs/6328021184/job/17345901218?pr=1482 and it's till crashing. Is there a way to test the installation from here ? So that I correct the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the released file have changed from 3.1.1 onward. I simply added a if else statement. I didn't know which synthaxe you would prefer.
I also don't know which version I should used between arm64 and x86_64, I'm happy to change if you think it's useful.
related to #2