Skip to content

Commit a5f6dce

Browse files
committed
fix(OpenAPITools#198): use "finish" event instead of "end" to avoid race condition
1 parent e1fab63 commit a5f6dce

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

apps/generator-cli/src/app/services/version-manager.service.spec.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -365,14 +365,15 @@ describe('VersionManagerService', () => {
365365

366366
const data = {
367367
pipe: jest.fn(),
368+
};
369+
370+
const file = {
368371
on: jest.fn().mockImplementation((listener, res) => {
369-
if (listener === 'end') {
372+
if (listener === 'finish') {
370373
return res();
371374
}
372375
})
373-
};
374-
375-
const file = Symbol();
376+
}
376377

377378
beforeEach(async () => {
378379
data.pipe.mockReset();

apps/generator-cli/src/app/services/version-manager.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ export class VersionManagerService {
113113
fs.ensureDirSync(this.storage);
114114
const file = fs.createWriteStream(filePath);
115115
res.data.pipe(file);
116-
res.data.on('end', resolve);
116+
file.on('finish', resolve);
117117
})
118118
)).toPromise();
119119

0 commit comments

Comments
 (0)