Skip to content

Bug in pushing SNAPSHOT JAR #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wing328 opened this issue Jun 1, 2018 · 2 comments
Closed

Bug in pushing SNAPSHOT JAR #198

wing328 opened this issue Jun 1, 2018 · 2 comments

Comments

@wing328
Copy link
Member

wing328 commented Jun 1, 2018

Description

We found that when the core team opens a PR with a new branch. Travis will deploy the snapshot JAR if the job succeeds, which is not the correct behavior as only the job targeting master should deploy the SNAPSHOT JAR:

[INFO] openapi-generator-project .......................... SUCCESS [  4.929 s]
[INFO] openapi-generator (core library) ................... SUCCESS [ 52.295 s]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 15.301 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [ 11.260 s]
[INFO] openapi-generator-gradle-plugin (gradle-plugin) .... SUCCESS [01:07 min]
[INFO] openapi-generator-online ........................... SUCCESS [ 16.057 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:49 min
[INFO] Finished at: 2018-06-01T08:56:39Z
[INFO] Final Memory: 67M/660M
[INFO] ------------------------------------------------------------------------
Finished mvn clean deploy for master
openapi-generator version

Latest master

Steps to reproduce

Create a branch and open a PR

Suggest a fix/enhancement

https://github.com/OpenAPITools/openapi-generator/blob/master/.travis.yml#L97 is a good starting point.

@wing328 wing328 added this to the 3.0.1 milestone Jun 1, 2018
@wing328 wing328 modified the milestones: 3.0.1, 3.0.2 Jun 11, 2018
@jimschubert
Copy link
Member

@wing328 this sould be fixed after my release management changes this weekend. I added:

[ "$TRAVIS_PULL_REQUEST" == "false" ]; then

@jmini
Copy link
Member

jmini commented Jun 12, 2018

Verified in #285, there is no maven deploy in the travis logs:

@jmini jmini closed this as completed Jun 12, 2018
jmini added a commit that referenced this issue Jun 18, 2018
nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this issue Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants