Skip to content

add option to set ownership of extraFiles #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Conversation

costowell
Copy link
Contributor

I was in need to setting ownership for some extra files and will probably need it more going forward so I added a --chown option and documentation too.

@costowell costowell force-pushed the main branch 2 times, most recently from 0450367 to e453e31 Compare January 2, 2025 20:51
@costowell costowell requested a review from Mic92 January 2, 2025 21:14
@Mic92
Copy link
Member

Mic92 commented Jan 7, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Jan 7, 2025

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link
Contributor

mergify bot commented Jan 7, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@Mic92 Mic92 enabled auto-merge February 7, 2025 08:33
auto-merge was automatically disabled February 17, 2025 04:17

Head branch was pushed to by a user without write access

@costowell
Copy link
Contributor Author

Ignore my previous message, everything looks good! Let me know if anything more needs to be done.

@Mic92 Mic92 enabled auto-merge February 24, 2025 05:55
@Mic92 Mic92 added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
@costowell
Copy link
Contributor Author

I'm a little unsure as to what to do. One of the tests failed due to a kernel panic, and I can't imagine that's due to my PR. Any comments or pointers would be greatly appreciated.

@Mic92
Copy link
Member

Mic92 commented Feb 25, 2025

@mergify queue

@Mic92 Mic92 added this pull request to the merge queue Feb 25, 2025
@Mic92
Copy link
Member

Mic92 commented Feb 25, 2025

I'm a little unsure as to what to do. One of the tests failed due to a kernel panic, and I can't imagine that's due to my PR. Any comments or pointers would be greatly appreciated.

No action required. This is general flakiness because we are close to the memory limit for some reason.

@Mic92
Copy link
Member

Mic92 commented Feb 25, 2025

Tried to mitigate it here: #473

Merged via the queue into nix-community:main with commit 7649236 Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants