only build NixOS if you have the install phase enabled #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gate `nixosSystem` build behind the `installPhase` flag. This ensures that the `nixosSystem` is only built when really needed by `nixos-anywhere`. This is especially useful if `nixpkgs.hostPlatform` is not set yet and building the derivation would error out. The build can be split in to phases with `nixos-facter` being run in the kexec phase. Potential Drawbacks: Since the `nixosSystem` is not built early in the invocation we can't fail fast on errors anymore. But this is only the case if the phases are already controlled from the "outside" eg. if `nixos-anywhere` is called without the install phase active.
a-kenji
force-pushed
the
gate-nixos-system
branch
from
8df29a9 to
1800547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.