Replace "any" types with "object" in errors and add types to OAuthError #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript "any" type allows anything (it can also be a string or a function etc). However, "object" type must be enforced on the
propertiesargument because object destructuring is used to merge user sent properties with its internal properties.Typescript has "object" type (https://www.typescriptlang.org/docs/handbook/basic-types.html#object); so, we can enforce using objects.
Additionally, I added types to OAuthError. All error classes inherited from OAuthError has
nameandcodein properties. So, I added these types to OAuthErrorpropertieswith excess property checking to allow additional attributes.