Skip to content

eslint-config-prettier is in dependencies, not devDependencies #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
themaxdavitt opened this issue May 2, 2021 · 2 comments
Closed

eslint-config-prettier is in dependencies, not devDependencies #5

themaxdavitt opened this issue May 2, 2021 · 2 comments

Comments

@themaxdavitt
Copy link

It looks like eslint-config-prettier is in the dependencies section of package.json - judging by where all the other eslint packages are, I'm guessing it should be in devDependencies.
jolyndenning pushed a commit that referenced this issue May 3, 2021
Move eslint-config-prettier to devDependencies. Resolves #5.
527e999
@jolyndenning jolyndenning mentioned this issue May 3, 2021
Merged
@jolyndenning
Copy link

Thanks for reporting this, I've fixed it in #6

@jolyndenning
Copy link

Fix released in https://github.com/node-loader/node-loader-core/releases/tag/v1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jolyndenning @themaxdavitt