Skip to content

support nodejs 18 and enable next loader in the chain to continue resolution #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2022
Merged

support nodejs 18 and enable next loader in the chain to continue resolution #5

merged 2 commits into from
Jul 18, 2022

Conversation

giltayar
Copy link
Contributor

No description provided.

jolyndenning
jolyndenning approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@jolyndenning jolyndenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

jolyndenning
jolyndenning reviewed Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@jolyndenning jolyndenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json change broke this. I will undo it.

jolyndenning
jolyndenning reviewed Jul 18, 2022
View reviewed changes
@jolyndenning jolyndenning merged commit e8cf0ea into node-loader:master Jul 18, 2022
@jolyndenning
Copy link
Collaborator

Released in https://github.com/node-loader/node-loader-import-maps/releases/tag/v1.1.0

@raihle
Copy link

raihle commented Aug 19, 2022

FYI (and perhaps for future searchers), this fix broke our (admittedly broken) config where @node-loader/http was before @node-loader/import-maps in the chain. Reversing the order fixed the problem.

Example error message:

Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only file and data URLs are supported by the default ESM loader. Received protocol 'https:'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolyndenning jolyndenning jolyndenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giltayar @jolyndenning @raihle