-
Notifications
You must be signed in to change notification settings - Fork 10
Is this going to replace oauthjs/express-oauth-server ? #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
following up here and wondering if the package will be published under the |
Yep would also like for this to published. |
Hey @relu91 @cancan101 @casret I did not watch the repo to I totally missed these comments. There are some other comments as well in the main repo asking for this. I would go an extra round and look for updating this repo. However, I do not actively use the oauth2 server with express so I need a bit of your requirements on what actually needs to be updated. |
@relu91 @cancan101 @casret please review this PR: #7 The more reviewers we have the faster we can publish |
Thank you for pinging me back. As I said in the beginning our main use case is to have a test server that is fully compliant with oAuth2 protocol to verify that our client is behaving correctly. I'll check #7 |
I got it reviewed from one maintainer of our org who uses express plus from an external so I published the updated version with no audit issues (updated dependencies) and the new OAuth2 server from this org. It's available from npm via: https://www.npmjs.com/package/@node-oauth/express-oauth-server |
I'll try ASAP and I'll let you know. |
How do I get typescript to see the types for this new package? When I had previously installing this package from GitHub, I had been using this package |
The types were related to the original repo. Since we didn't change the API it should work if we create a types.ts file and copy the one from the types repo, right? |
@cancan101 @relu91 the types would be added in this PR: #11 please review and confirm/deny so we can merge and move forward with this :-) |
Everything was fine, thank you really much! |
Just passing by and I was wondering if this fork will be published under https://www.npmjs.com/package/express-oauth-server soon or after. With https://github.com/eclipse/thingweb.node-wot we are having annoying
npm audit
problems that I would like to resolve. Thank you for your time! :)The text was updated successfully, but these errors were encountered: