Skip to content

Is this going to replace oauthjs/express-oauth-server ? #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
relu91 opened this issue Feb 25, 2022 · 11 comments · Fixed by #7
Closed

Is this going to replace oauthjs/express-oauth-server ? #5

relu91 opened this issue Feb 25, 2022 · 11 comments · Fixed by #7

Comments

@relu91
Copy link

relu91 commented Feb 25, 2022

Just passing by and I was wondering if this fork will be published under https://www.npmjs.com/package/express-oauth-server soon or after. With https://github.com/eclipse/thingweb.node-wot we are having annoying npm audit problems that I would like to resolve. Thank you for your time! :)

@cancan101
Copy link

following up here and wondering if the package will be published under the @node-oauth org on npm?

@casret
Copy link

casret commented Jul 15, 2022

Yep would also like for this to published.

@jankapunkt
Copy link
Member

Hey @relu91 @cancan101 @casret I did not watch the repo to I totally missed these comments. There are some other comments as well in the main repo asking for this.

I would go an extra round and look for updating this repo. However, I do not actively use the oauth2 server with express so I need a bit of your requirements on what actually needs to be updated.

@jankapunkt jankapunkt linked a pull request May 26, 2023 that will close this issue
@jankapunkt
Copy link
Member

@relu91 @cancan101 @casret please review this PR: #7 The more reviewers we have the faster we can publish

@relu91
Copy link
Author

relu91 commented May 26, 2023

Thank you for pinging me back. As I said in the beginning our main use case is to have a test server that is fully compliant with oAuth2 protocol to verify that our client is behaving correctly. I'll check #7

@jankapunkt
Copy link
Member

I got it reviewed from one maintainer of our org who uses express plus from an external so I published the updated version with no audit issues (updated dependencies) and the new OAuth2 server from this org.

It's available from npm via: https://www.npmjs.com/package/@node-oauth/express-oauth-server

@relu91
Copy link
Author

relu91 commented May 26, 2023

I'll try ASAP and I'll let you know.

@cancan101
Copy link

How do I get typescript to see the types for this new package? When I had previously installing this package from GitHub, I had been using this package @types/express-oauth-server to add types. Now that I am installing from npm using @node-oauth/express-oauth-server, typescript is no longer seeing the types.

@jankapunkt
Copy link
Member

The types were related to the original repo. Since we didn't change the API it should work if we create a types.ts file and copy the one from the types repo, right?

@jankapunkt
Copy link
Member

@cancan101 @relu91 the types would be added in this PR: #11 please review and confirm/deny so we can merge and move forward with this :-)

@relu91
Copy link
Author

relu91 commented May 30, 2023

Everything was fine, thank you really much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants