-
Notifications
You must be signed in to change notification settings - Fork 10
Update deps and use @node-oauth/oauth2-server #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, and from a functionality standpoint as well, I can confirm that things seem to be working fine. I've tested the following grant types from my framework and no problems with this:
- Code Response Type
- Authorization Code
- Password
- Client Credentials
Might also be a good idea to remove bluebird dependency since promises are native in a good amount of node versions. But I don't know if there is already a plan for this. |
@shrihari-prakash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review Completed
Thanks @HappyZombies @shrihari-prakash I will merge and then create a release under our org |
Test this with your local setup by cloning this repo and checkout the branch
3.0.0
Other notes:
oauthjs
before)