Skip to content

Update deps and use @node-oauth/oauth2-server #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 26, 2023
Merged

Update deps and use @node-oauth/oauth2-server #7

merged 9 commits into from
May 26, 2023

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented May 26, 2023

  • use @node-oauth/oauth2-server
  • update all dependencies to latest
  • add code coverage to tests
  • add GitHub actions CI
  • replace jshint with eslint

Test this with your local setup by cloning this repo and checkout the branch 3.0.0

Other notes:

  • we don't move to ES6 in this PR, because that would make the PR way too big!
  • there are no functional changes in the code so it should be non-breaking (although the transition to @node-oauth/oauth2-server would be breaking if you used oauthjs before)

Copy link

@shrihari-prakash shrihari-prakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, and from a functionality standpoint as well, I can confirm that things seem to be working fine. I've tested the following grant types from my framework and no problems with this:

  1. Code Response Type
  2. Authorization Code
  3. Password
  4. Client Credentials

@shrihari-prakash
Copy link

Might also be a good idea to remove bluebird dependency since promises are native in a good amount of node versions. But I don't know if there is already a plan for this.

@HappyZombies
Copy link
Member

HappyZombies commented May 26, 2023

Might also be a good idea to remove bluebird dependency since promises are native in a good amount of node versions. But I don't know if there is already a plan for this.

@shrihari-prakash
I agree but let's keep that for another version/MR, this whole module should/will probably be refactored entirely at some point. The focus on this MR is to just update the node-oauth dependency and other deps.

Copy link
Member

@HappyZombies HappyZombies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Completed

@jankapunkt
Copy link
Member Author

Thanks @HappyZombies @shrihari-prakash I will merge and then create a release under our org

@jankapunkt jankapunkt merged commit c2a8b11 into master May 26, 2023
@jankapunkt jankapunkt mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants