Skip to content

4.0.0 - Migrate to async/await #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 5, 2024
Merged

4.0.0 - Migrate to async/await #22

merged 19 commits into from
Feb 5, 2024

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Jan 3, 2024 •
edited
Loading

Might be breaking for older setups!

  • bump minimal node to 16
  • upgrade @node-oauth/oauth2-server to 5.1.0
  • drop bluebird dependency
  • upgrade all deps / dev-deps
  • refactor all code to minimum es6
  • use native async/await
  • update ci to use minimum node 16
  • update readme and changelog
  • make express peer depdendency with * value so there will always be the express version used that is installed by users
  • test coverage to 100%

@jankapunkt jankapunkt changed the title Migrate es 6 4.0.0 - Migrate to async/await Jan 3, 2024
jorenvandeweyer
jorenvandeweyer requested changes Jan 4, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 4, 2024
View reviewed changes
test/integration/index_test.js
it('should return an error if `model` is empty', function(done) {
const oauth = new ExpressOAuthServer({ model: {} });

app.use(oauth.authorize());

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
test/integration/index_test.js
}
};
const oauth = new ExpressOAuthServer({ model });
app.use(oauth.authenticate());

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
@jankapunkt
Copy link
Member Author

@jorenvandeweyer please note that express is now a peer dependency, since there will soon be a major transition to express 5 while many ppl will still run on express 4 and from what I see this peer dependency is a good way to avoid major version conflicts by always pointing to the user's express installation. On the tests we use latest express 4 rn, though

@kanelloc kanelloc mentioned this pull request Jan 8, 2024
Closed
@jankapunkt jankapunkt linked an issue Jan 8, 2024 that may be closed by this pull request
Errors problems with @node-oauth/express-oauth-server and @node-oauth/oauth2-server version 5 #23
Closed
@jankapunkt
Copy link
Member Author

@jorenvandeweyer resolved the issues, can you please review, again?

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2024
View reviewed changes
docs/scripts/prettify/lang-css.js
@@ -0,0 +1,2 @@
PR.registerLangHandler(PR.createSimpleLexer([["pln",/^[\t\n\f\r ]+/,null," \t\r\n "]],[["str",/^"(?:[^\n\f\r"\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*"/,null],["str",/^'(?:[^\n\f\r'\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*'/,null],["lang-css-str",/^url\(([^"')]*)\)/i],["kwd",/^(?:url|rgb|!important|@import|@page|@media|@charset|inherit)(?=[^\w-]|$)/i,null],["lang-css-kw",/^(-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*)\s*:/i],["com",/^\/\*[^*]*\*+(?:[^*/][^*]*\*+)*\//],["com",

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '"' and containing many repetitions of '\\\n'.
docs/scripts/prettify/lang-css.js
@@ -0,0 +1,2 @@
PR.registerLangHandler(PR.createSimpleLexer([["pln",/^[\t\n\f\r ]+/,null," \t\r\n "]],[["str",/^"(?:[^\n\f\r"\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*"/,null],["str",/^'(?:[^\n\f\r'\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*'/,null],["lang-css-str",/^url\(([^"')]*)\)/i],["kwd",/^(?:url|rgb|!important|@import|@page|@media|@charset|inherit)(?=[^\w-]|$)/i,null],["lang-css-kw",/^(-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*)\s*:/i],["com",/^\/\*[^*]*\*+(?:[^*/][^*]*\*+)*\//],["com",

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with ''' and containing many repetitions of '\\\n'.
docs/scripts/prettify/lang-css.js
@@ -0,0 +1,2 @@
PR.registerLangHandler(PR.createSimpleLexer([["pln",/^[\t\n\f\r ]+/,null," \t\r\n "]],[["str",/^"(?:[^\n\f\r"\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*"/,null],["str",/^'(?:[^\n\f\r'\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*'/,null],["lang-css-str",/^url\(([^"')]*)\)/i],["kwd",/^(?:url|rgb|!important|@import|@page|@media|@charset|inherit)(?=[^\w-]|$)/i,null],["lang-css-kw",/^(-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*)\s*:/i],["com",/^\/\*[^*]*\*+(?:[^*/][^*]*\*+)*\//],["com",

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '_\\\\' and containing many repetitions of '00\\\\'.
docs/scripts/prettify/lang-css.js
@@ -0,0 +1,2 @@
PR.registerLangHandler(PR.createSimpleLexer([["pln",/^[\t\n\f\r ]+/,null," \t\r\n "]],[["str",/^"(?:[^\n\f\r"\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*"/,null],["str",/^'(?:[^\n\f\r'\\]|\\(?:\r\n?|\n|\f)|\\[\S\s])*'/,null],["lang-css-str",/^url\(([^"')]*)\)/i],["kwd",/^(?:url|rgb|!important|@import|@page|@media|@charset|inherit)(?=[^\w-]|$)/i,null],["lang-css-kw",/^(-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*)\s*:/i],["com",/^\/\*[^*]*\*+(?:[^*/][^*]*\*+)*\//],["com",
/^(?:<\!--|--\>)/],["lit",/^(?:\d+|\d*\.\d+)(?:%|[a-z]+)?/i],["lit",/^#[\da-f]{3,6}/i],["pln",/^-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*/i],["pun",/^[^\s\w"']+/]]),["css"]);PR.registerLangHandler(PR.createSimpleLexer([],[["kwd",/^-?(?:[_a-z]|\\[\da-f]+ ?)(?:[\w-]|\\\\[\da-f]+ ?)*/i]]),["css-kw"]);PR.registerLangHandler(PR.createSimpleLexer([],[["str",/^[^"')]+/]]),["css-str"]);

Check failure

Code scanning / CodeQL

Bad HTML filtering regexp

This regular expression only parses --> and not --!> as a HTML comment end tag.
@jankapunkt
Copy link
Member Author

Published @node-oauth/[email protected]

@jankapunkt jankapunkt linked an issue Jan 9, 2024 that may be closed by this pull request
Remove express as a dependency #13
Closed
This was referenced Jan 27, 2024
Open
Open
@jankapunkt jankapunkt merged commit deb11f2 into master Feb 5, 2024
@dhensby dhensby deleted the migrate-es-6 branch February 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenvandeweyer jorenvandeweyer jorenvandeweyer approved these changes

@dhensby dhensby Awaiting requested review from dhensby

@HappyZombies HappyZombies Awaiting requested review from HappyZombies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jankapunkt @jorenvandeweyer