Marked verifyScope function as optional in model types. #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankapunkt
requested changes
Aug 4, 2023
jankapunkt
approved these changes
Aug 4, 2023
|
@jankapunkt , I will let you merge once the pipelines are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When you do not implement
verifyScopemethod in the model, TypeScript currently throws an error even though you do not need to implement this method in all cases. There are a lot of instances whereverifyScopemethod is optional. There is already some error mechanisms to throw errors in cases whereverifyScopeis required and is not implemented. So making this implementation optional in models.Linked issue(s)
#202
Involved parts of the project
Typings
Added tests?
NA
OAuth2 standard
NA
Reproduction
TypeScript will not throw errors anymore if you do not implement
verifyScopewhen using your own authenticate handler.