tests: add deep integration tests #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankapunkt
added
in progress 👨💻
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }; | ||
| const authorizationCode = 'long-authz-code-?'; | ||
| const accessTokenDoc = { | ||
| accessToken: 'some-access-token-code-?', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
There was a problem hiding this comment.
This is just tests, can be ignored
jorenvandeweyer
approved these changes
Aug 26, 2023
|
@jorenvandeweyer you are right, let's merge and open a "Part II" PR for this |
This was referenced Aug 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the integration tests to cover integrity of the model parameters.
Furthermore, compliance tests are added, where possible.
Finally, coverage is improved, if possible.
Linked issue(s)
#219
Involved parts of the project
Tests, grant types, handlers
OAuth2 standard
Compliance tests to deeply conform RFC 6749
Reproduction
checkout branch, run
npm run testornpm run test:coverage