Improve bearer validation #234
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankapunkt
reviewed
Aug 28, 2023
|
Maybe we should also add a test or two, checking for a valid bearer token and a set of invalid bearer token. |
@jankapunkt I'll add some tests after 5.0.0 is merged into development |
jankapunkt
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Validate the bearer token with the correct regex as described in the spec.
Linked issue(s)
fixes #127
Involved parts of the project
authenticate handler
Added tests?
already existed
OAuth2 standard
https://datatracker.ietf.org/doc/html/rfc6750#section-2.1
Reproduction
NA