-
-
Notifications
You must be signed in to change notification settings - Fork 51
Fixes ignoring scope on refresh token call #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ignoring scope on refresh token call #238
Conversation
@jankapunkt I targeted the PR to the I think we should asap merge |
@jankapunkt , @jorenvandeweyer , will there be one more RC to test this change? I think this is already breaking with my project and maybe I can do a code change and test this to see if things are smooth before 5.0.0? |
@jankapunkt can there be a RC of this PR? |
Hi @jorenvandeweyer @shrihari-prakash I was sick the last days jost got back today 💫 I will merge later today and create an rc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorenvandeweyer I added some comments, can we shortly discuss before merging?
@jorenvandeweyer would you mind shortly reviewing my comments? I think it's ready to merge I just want to make sure there is nothing missing etc. I can create a new release ASAP once it's merged |
…/node-oauth2-server into feature/scope-validation
@jankapunkt sorry for the delay, I updated the PR. It should be ready to be merged now! |
Summary
BREAKING:
validateScope
must now only return an array of strings or a falsy value.Linked issue(s)
#104 #194
Involved parts of the project
Scopes
Added tests?
Yes & updated existing tests
OAuth2 standard
See #104