Skip to content

hotfix: type and build fixes #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

hotfix: type and build fixes #177

merged 1 commit into from
Jan 20, 2025

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jan 20, 2025

This PR does a bunch of hotfixes:

  • Fix generation that was not considering REPLACEME
  • Fix declare global for some types
  • Updated Gitignore
  • Also Minify CSS

Closes #176

@ovflowd ovflowd requested a review from a team as a code owner January 20, 2025 01:27
@ovflowd
Copy link
Member Author

ovflowd commented Jan 20, 2025

cc @nodejs/web-infra I'm fast-tracking this PR.

@ovflowd ovflowd merged commit 5c5884c into main Jan 20, 2025
7 checks passed
@ovflowd ovflowd deleted the hotfix/type-and-build-fix branch January 20, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

actual implementation is broken
1 participant