ncu-ci: parse console text of the first failed phase #351
Conversation
Previously we try to detect the type of the failed phase and return a generic build failure when the job failed in a non-test phase. This is not really necessary - the console text parser is capable of detecting the actual build failure from even the console text of the build phase. Also hard-coding the test phase name makes the detection fragile when there are configuration changes in the Jenkins. So we should just skip the detection.
|
cc @nodejs/automation |
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 75.8% 75.95% +0.14%
==========================================
Files 21 21
Lines 1368 1364 -4
==========================================
- Hits 1037 1036 -1
+ Misses 331 328 -3
Continue to review full report at Codecov.
|
|
@evenstensberg What do you mean by json side of things? |
|
I’m just trying to understand the source of truth. New to the automation team so trying to get insight |
|
@evenstensberg The source of truth is Jenkins. This tool adapts to the configurations there. |
|
Okay so can't change output instead of removing the test? CC @mhdawson for reviews |
|
@evenstensberg There isn't any test actually removed here? It simply removes an false early return and always run the logic below no matter how the phases are named. |
|
Okay gotcha, thanks for elaborating! |
Previously we try to detect the type of the failed phase
and return a generic build failure when the job failed in a
non-test phase. This is not really necessary - the console
text parser is capable of detecting the actual build failure
from even the console text of the build phase. Also hard-coding
the test phase name makes the detection fragile when there
are configuration changes in the Jenkins. So we should just
skip the detection.
Fixes: #344