doc: add contributing guide and license #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
======================================
Coverage 96.8% 96.8%
======================================
Files 13 13
Lines 438 438
======================================
Hits 424 424
Misses 14 14Continue to review full report at Codecov.
|
joyeecheung
commented
Nov 3, 2017
| @@ -74,7 +74,7 @@ $ get-metadata $PRID >> msg.txt | |||
| $ git commit --amend -F msg.txt | |||
| ``` | |||
|
|
|||
| ### TODO | |||
| ### Features | |||
There was a problem hiding this comment.
This is not an accident XD
maclover7
approved these changes
Nov 3, 2017
Tiriel
approved these changes
Nov 3, 2017
|
It does! Letting a bit more time for reviews before merge |
|
I think we should be good to go, if there are any more comments please raise an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/joyeecheung/node-core-utils/issues/59
The contributing guide is largely borrowed from the llnode one, although during this patch I noticed that one needs update as well...that one was largely borrowed from the node core one, I dropped a few requirements e.g. wrapping commit message header line in 50 chars because they feel a bit lengthy to me.