-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
doc: mark type stripping as release candidate #57705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:mark-ts-as-release-candidate
Apr 3, 2025
Merged
doc: mark type stripping as release candidate #57705
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:mark-ts-as-release-candidate
Apr 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
mcollina
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
targos
approved these changes
Apr 1, 2025
MoLow
approved these changes
Apr 1, 2025
JakobJingleheimer
approved these changes
Apr 1, 2025
jasnell
approved these changes
Apr 1, 2025
ljharb
approved these changes
Apr 1, 2025
JungMinu
approved these changes
Apr 1, 2025
bjohansebas
approved these changes
Apr 1, 2025
Lxxyx
approved these changes
Apr 2, 2025
GeoffreyBooth
approved these changes
Apr 2, 2025
Landed in 3984bc1 |
JonasBa
pushed a commit
to JonasBa/node
that referenced
this pull request
Apr 11, 2025
PR-URL: nodejs#57705 Refs: nodejs/typescript#24 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57705 Refs: nodejs/typescript#24 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57705 Refs: nodejs/typescript#24 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
strip-types
Issues or PRs related to strip-types support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/typescript#24
The design of this feature is pretty much stable and we have just been working on bug fixing and aesthetic improvements like error messages.
There is 1 issue open right now, and not many issues opened in general so I feel pretty confident in marking this as release candidate
cc @nodejs/typescript