Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(learn): organise TypeScript articles from simplest to advanced usage #7465

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

JakobJingleheimer
Copy link
Member

Currently, the articles are sequenced advanced to simplest, which I think is backwards.

@JakobJingleheimer JakobJingleheimer requested review from a team as code owners February 2, 2025 14:34
Copy link

vercel bot commented Feb 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 1, 2025 10:54am

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Feb 2, 2025

Hold on, need to sync with #7440 (comment)

Edit:

Result of discution is #7440 (comment)

@AugustinMauroy AugustinMauroy added content Issues/pr concerning content learn Issues/pr concerning the learn section labels Feb 23, 2025
@avivkeller
Copy link
Member

@JakobJingleheimer could you please resolve @styfle's concerns, and resolve the merge conflicts? Once that's one, this should be good to merge!

Co-authored-by: Steven <[email protected]>
Signed-off-by: Aviv Keller <[email protected]>
@avivkeller
Copy link
Member

@AugustinMauroy you to perchance have the bandwidth to resolve the conflicts with this PR? I don't have the ability to do it right now. (Otherwise I can do it later / tomorrow)

Thanks!

Copy link
Contributor

github-actions bot commented Apr 1, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 93 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Apr 1, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.61% (495/585) 76.03% (165/217) 86.99% (107/123)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 5.154s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.514s ⏱️

@avivkeller avivkeller enabled auto-merge April 1, 2025 10:59
@avivkeller avivkeller disabled auto-merge April 1, 2025 11:00
@avivkeller
Copy link
Member

@nodejs/typescript please re review

@avivkeller avivkeller added this pull request to the merge queue Apr 1, 2025
Merged via the queue into main with commit 913bfff Apr 1, 2025
15 checks passed
@avivkeller avivkeller deleted the learn/ts-article-sequence branch April 1, 2025 11:14
@JakobJingleheimer
Copy link
Member Author

Oh whoops, sorry, I missed your request @avivkeller. Thanks for handling and carrying this over the finish-line!

@avivkeller
Copy link
Member

No worries! All is well that ends well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues/pr concerning content learn Issues/pr concerning the learn section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants