-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tailwind): migrate to v4 #7507
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
something that may help you:
and for css module: https://tailwindcss.com/docs/compatibility#css-modules |
Yep, with that I made the first commit, I thought it was going to do most of the work |
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
Hey @bjohansebas I assume this is still a WIP? |
Yep, I'll continue with this later. |
tysm for your contributions <3 |
I think I'll continue after you all have done the migration to the new version of Next.js. |
@bjohansebas bump claudio had merge the pr. You can have fun with git conflict 😁 |
908dbb9
to
9859b48
Compare
f48f718
to
4495637
Compare
I think it's ready for review |
Shadow on toast didn't correctly applied |
But other than that, everything looks good :-) |
I feel like it's something related to Storybook because on the page I can see the shadow of the toast. Either way, I can check it again by Friday/Saturday. |
fixed ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's do this ✨
thanks for the help |
Description
Upgrade to tailwind-css major 4. And simplified use of postcss.
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.