Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tailwind): migrate to v4 #7507

Merged
merged 15 commits into from
Apr 3, 2025
Merged

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Feb 23, 2025

Description

Upgrade to tailwind-css major 4. And simplified use of postcss.

Check List

  • [] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [] I have run npm run format to ensure the code follows the style guide.
  • [] I have run npm run test to check if all tests are passing.
  • [] I have run npx turbo build to check if the website builds without errors.
  • [] I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Feb 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 3, 2025 7:10am

@AugustinMauroy
Copy link
Member

something that may help you:

npx @tailwindcss/upgrade

and for css module: https://tailwindcss.com/docs/compatibility#css-modules

@bjohansebas
Copy link
Member Author

Yep, with that I made the first commit, I thought it was going to do most of the work

Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@ovflowd
Copy link
Member

ovflowd commented Mar 1, 2025

Hey @bjohansebas I assume this is still a WIP?

Copy link
Contributor

github-actions bot commented Mar 1, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.73% (494/583) 76.03% (165/217) 86.99% (107/123)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.546s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.21s ⏱️

@bjohansebas
Copy link
Member Author

Yep, I'll continue with this later.

@ovflowd
Copy link
Member

ovflowd commented Mar 1, 2025

Yep, I'll continue with this later.

tysm for your contributions <3

@bjohansebas
Copy link
Member Author

I think I'll continue after you all have done the migration to the new version of Next.js.

@AugustinMauroy
Copy link
Member

@bjohansebas bump claudio had merge the pr. You can have fun with git conflict 😁

@bjohansebas
Copy link
Member Author

I think it's ready for review

@AugustinMauroy
Copy link
Member

Shadow on toast didn't correctly applied

@avivkeller
Copy link
Member

Shadow on toast didn't correctly applied

But other than that, everything looks good :-)

@bjohansebas
Copy link
Member Author

I feel like it's something related to Storybook because on the page I can see the shadow of the toast. Either way, I can check it again by Friday/Saturday.

@AugustinMauroy
Copy link
Member

I feel like it's something related to Storybook because on the page I can see the shadow of the toast. Either way, I can check it again by Friday/Saturday.

fixed !

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's do this ✨

@ovflowd ovflowd merged commit 77c6c7e into nodejs:main Apr 3, 2025
16 checks passed
@bjohansebas
Copy link
Member Author

thanks for the help

@bjohansebas bjohansebas deleted the tailwind-update branch April 3, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants