chore: remove dead code #7587
Merged
chore: remove dead code #7587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused code and dependencies from the apps/site folder to clean up the codebase.
- Removal of dead type definitions in og.ts and frontmatter.ts
- Removal of unused helper functions and constants in next.helpers.mjs and next.constants.mjs
- Removal of dead components and mocks, including withRouterSelect.tsx, ActiveLink.tsx, and mocks files
- Update to dependency configuration in .github/dependabot.yml
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/site/types/og.ts | Removed unused SVG type definition |
| apps/site/types/frontmatter.ts | Removed legacy frontmatter interfaces |
| apps/site/next.helpers.mjs | Removed unused helper functions |
| apps/site/next.constants.mjs | Removed unused regex constant |
| apps/site/components/withRouterSelect.tsx | Removed dead component code |
| apps/site/components/mocks/next-image.mjs | Removed unused mock for next-image |
| apps/site/components/mocks/client-context.mjs | Removed unused client context mock |
| apps/site/components/Common/ActiveLink.tsx | Removed unused component code |
| .github/dependabot.yml | Updated dependency patterns by removing one |
Files not reviewed (1)
- apps/site/package.json: Language not supported
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
|
AugustinMauroy
approved these changes
Mar 30, 2025
araujogui
approved these changes
Apr 1, 2025
|
Oh ok, lgtm then |
bmuenzenmeyer
approved these changes
Apr 1, 2025
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some unused code / dependencies in the
apps/sitefolder.(I used
knipto find a large list, and went through to see what was actually unused).