chore: refactor the generateBlogData function
#7607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the generateBlogData function to simplify the code and improve performance by leveraging Promise.all for parallel file processing.
- Apply Promise.all with a map over filenames to process file frontmatter concurrently.
- Simplify the accumulation of raw frontmatter and resolution logic for each file.
dario-piotrowicz
changed the title
generateBlogData functiongenerateBlogData function
dario-piotrowicz
force-pushed
the
dario/improve-generateBlogData
branch
from
9c5c742 to
c497efa
Compare
dario-piotrowicz
force-pushed
the
dario/improve-generateBlogData
branch
from
c497efa to
a0c01a7
Compare
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
|
ovflowd
reviewed
Apr 1, 2025
ovflowd
approved these changes
Apr 1, 2025
AugustinMauroy
approved these changes
Apr 1, 2025
aymen94
approved these changes
Apr 2, 2025
shanpriyan
approved these changes
Apr 2, 2025
bmuenzenmeyer
approved these changes
Apr 2, 2025
dario-piotrowicz
added a commit
to dario-piotrowicz/nodejs.org
that referenced
this pull request
Apr 3, 2025
This reverts commit b7364b9.
5 tasks
dario-piotrowicz
added a commit
to dario-piotrowicz/nodejs.org
that referenced
this pull request
Apr 3, 2025
dario-piotrowicz
added a commit
to dario-piotrowicz/nodejs.org
that referenced
this pull request
Apr 3, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is simply am refactoring the
generateBlogDatafunction, as I was working around the function I noticed that the code could be simplified andPromise.allcould be used to read the files frontmatter in parallel, hopefully this makes sense and I am not missing some nuances in the code 😅If the changes here are correct they should both simplify the code and make it faster 🙂
Validation
I simply run
npm run devto manually validate that this is working as intendedRelated Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.