Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated docs for releases #7616

Merged
merged 2 commits into from
Apr 6, 2025

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Apr 3, 2025

This PR updates the docs for Releases, further tapping into Community and Official requirements.

@Copilot Copilot bot review requested due to automatic review settings April 3, 2025 15:01
@ovflowd ovflowd requested a review from a team as a code owner April 3, 2025 15:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • apps/site/pages/en/about/previous-releases.mdx: Language not supported

Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 3, 2025 3:30pm

@ovflowd
Copy link
Member Author

ovflowd commented Apr 3, 2025

cc @nodejs/nodejs-website

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.73% (494/583) 76.03% (165/217) 86.99% (107/123)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.96s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.445s ⏱️

@avivkeller avivkeller linked an issue Apr 3, 2025 that may be closed by this pull request
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but for our own sake of future documentation, can we link to the discussions (in the PR, not the code) that led to these criteria? I am pretty sure many conversations happened. I dont want the website team to have to defend itself months from now.

@avivkeller
Copy link
Member

@avivkeller avivkeller added this pull request to the merge queue Apr 6, 2025
Merged via the queue into main with commit 28a3dab Apr 6, 2025
15 checks passed
@avivkeller avivkeller deleted the chore/update-docs-based-on-agreements branch April 6, 2025 23:45
@avivkeller
Copy link
Member

avivkeller commented Apr 6, 2025

Merging, as:

  • Over a month has passed since the original suggestion with no objections and multiple👍s from the package maintenance team
  • 72 hours have passed since the PR was opened, with no objections, and approvals from package maintenance team members

@GeoffreyBooth
Copy link
Member

I just learned of this because it closed the original issue. Next time please comment on the issue when you open a PR to address it, and tagging the package maintenance team would help too.

@avivkeller
Copy link
Member

avivkeller commented Apr 7, 2025

😅 that's on me! I didn't realize that the teams weren't aware of this PR, I thought you all knew.

I'll keep that in account for the future.

@ovflowd
Copy link
Member Author

ovflowd commented Apr 7, 2025

I just learned of this because it closed the original issue. Next time please comment on the issue when you open a PR to address it, and tagging the package maintenance team would help too.

Hmm, was the issue connected somewhere? I don't see any issue linked here?

@ovflowd
Copy link
Member Author

ovflowd commented Apr 7, 2025

Oh, Aviv linked it. Apologies, @GeoffreyBooth, I also forgot to tag package maintenance here. Would you feel comfortable reviewing the contents of this PR? I can address any feedback in a follow-up PR!


| Requirements (Official Installation Methods) |
| :------------------------------------------------------------------------------------------------------------------------------- |
| New Node.js releases must be available simultaneously with the official release. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe Docker releases are available simultaneously with the official release even though its listed as Official here:

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that is correct. But it is a 1st party installation method (provided by the Node project) hence it is official, although it does not fulfils that specific criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define criteria for inclusion in the Downloads page
7 participants