-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated docs for releases #7616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- apps/site/pages/en/about/previous-releases.mdx: Language not supported
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cc @nodejs/nodejs-website |
Lighthouse Results
|
Signed-off-by: Claudio W. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but for our own sake of future documentation, can we link to the discussions (in the PR, not the code) that led to these criteria? I am pretty sure many conversations happened. I dont want the website team to have to defend itself months from now.
Discussions (that I am aware of): |
Merging, as:
|
I just learned of this because it closed the original issue. Next time please comment on the issue when you open a PR to address it, and tagging the package maintenance team would help too. |
😅 that's on me! I didn't realize that the teams weren't aware of this PR, I thought you all knew. I'll keep that in account for the future. |
Hmm, was the issue connected somewhere? I don't see any issue linked here? |
Oh, Aviv linked it. Apologies, @GeoffreyBooth, I also forgot to tag package maintenance here. Would you feel comfortable reviewing the contents of this PR? I can address any feedback in a follow-up PR! |
|
||
| Requirements (Official Installation Methods) | | ||
| :------------------------------------------------------------------------------------------------------------------------------- | | ||
| New Node.js releases must be available simultaneously with the official release. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that is correct. But it is a 1st party installation method (provided by the Node project) hence it is official, although it does not fulfils that specific criteria.
This PR updates the docs for Releases, further tapping into Community and Official requirements.