chore(actions): remove base job
#7624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aviv Keller <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/lint-and-tests.yml:33
- The new environment variable TURBO_ARGS is set to '--force' whereas the original value was '--force=true'. Please verify if this change in value is intentional and update it accordingly if needed.
TURBO_ARGS: --force
avivkeller
added
infrastructure
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
|
MattIPv4
reviewed
Apr 5, 2025
Co-authored-by: Matt Cowley <[email protected]> Signed-off-by: Aviv Keller <[email protected]>
bjohansebas
approved these changes
Apr 5, 2025
github-actions
bot
removed
the
github_actions:pull-request
|
Ah, because these use |
MattIPv4
approved these changes
Apr 5, 2025
bmuenzenmeyer
requested changes
Apr 5, 2025
bmuenzenmeyer
approved these changes
Apr 5, 2025
ovflowd
approved these changes
Apr 7, 2025
aymen94
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we even have this job? Doesn't it make more sense to store these in the environment, rather than trigger an entire runner just to set a single variable?