fix(heading): improve heading style #7628
Conversation
AugustinMauroy
added
fast-track
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Co-authored-by: Copilot <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>
Unit Test Coverage Report
|
| @@ -75,7 +75,8 @@ main { | |||
| dark:text-white; | |||
| } | |||
|
|
|||
| a, | |||
| /* link that isn't inside a heading */ | |||
| a:not(h1 > a):not(h2 > a):not(h3 > a):not(h4 > a):not(h5 > a):not(h6 > a), | |||
| @@ -95,7 +94,7 @@ | |||
| --font-xs-line-height: 1rem; | |||
| --font-sm: 0.87rem; | |||
| --font-sm-line-height: 1.25rem; | |||
| --font-base: 1rem; | |||
| --font-base: 0.9rem; | |||
There was a problem hiding this comment.
Hmmm, did we not use something else before? What were we using for defining base font size?
There was a problem hiding this comment.
IDK maybe coming from codemod ?
There was a problem hiding this comment.
Can you check what was the original value?
There was a problem hiding this comment.
nodejs.org/packages/ui-components/tailwind.config.ts
Lines 90 to 108 in 5230197
There was a problem hiding this comment.
I looked to the Wayback machine and apparently it was always 16px. That's interestingly odd. Let's undo this change then and keep base as 1rem.
There was a problem hiding this comment.
It just feels odd to me that the content font size is larger than, for example, the sidebar or other elements such as tables and so on. What do you all think, @nodejs/nodejs-website?
There was a problem hiding this comment.
The font values weren't updated by the codemod, i had to do it manually :(.
I'm trying to figure out what's different compared to what's in production, but I can't spot any difference.
For posterity, can you link the slack discussion? |
Normally it's okay now |
Description
Fix bugs introduced by migration of tailwind v4 or monorepo.
Validation
Related Issues
No related issues just slack discussion
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.