-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
refactor: remove useless promise.all #7629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
apps/site/next-data/generators/releaseData.mjs:36
- [nitpick] The variable 'nodeReleases' may be misleading since it no longer holds a promise. Consider renaming it to 'releases' for clarity.
const nodeReleases = majors.map(major => {
Lighthouse Results
|
@nodejs/nodejs-website Fast-tracking this due to its simplicity. |
Description
Removes useless
Promise.all
since there's nothing async in the loop.Validation
Related Issues
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.