Skip to content

refactor: remove useless promise.all #7629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

araujogui
Copy link
Member

Description

Removes useless Promise.all since there's nothing async in the loop.

Validation

curl http://localhost:3000/en/next-data/release-data

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot AI review requested due to automatic review settings April 7, 2025 19:21
@araujogui araujogui requested a review from a team as a code owner April 7, 2025 19:21
Copy link

vercel bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 7, 2025 7:23pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

apps/site/next-data/generators/releaseData.mjs:36

  • [nitpick] The variable 'nodeReleases' may be misleading since it no longer holds a promise. Consider renaming it to 'releases' for clarity.
const nodeReleases = majors.map(major => {

Copy link
Contributor

github-actions bot commented Apr 7, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 90 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Apr 7, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.7% (493/582) 76.03% (165/217) 86.88% (106/122)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.978s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.387s ⏱️

@araujogui
Copy link
Member Author

@nodejs/nodejs-website Fast-tracking this due to its simplicity.

@araujogui araujogui added the fast-track Fast Tracking PRs label Apr 8, 2025
@AugustinMauroy AugustinMauroy enabled auto-merge April 8, 2025 15:14
@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Apr 8, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 8, 2025
@AugustinMauroy AugustinMauroy added this pull request to the merge queue Apr 8, 2025
Merged via the queue into nodejs:main with commit 0a04f29 Apr 8, 2025
26 checks passed
@araujogui araujogui deleted the refactor/release-data branch April 8, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants