-
Notifications
You must be signed in to change notification settings - Fork 6.3k
chore(deps): re-sync lockfile #7634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
good work❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm -1 on the practice, as it's imprecise and very hard to review.
I didn't get what is the issue why "updating" the lock file ? |
Regenerating the lockfile ensures that the package versions we install are the best ones available. Over time, the file can slightly differ from its optimal state, mainly because Dependabot updates only a few packages at a time in isolation, not taking into account if a specific package has a better version available that suits our specified requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
putting an explicit block on this til we have consensus
I am -1 to this practice -- I have never encountered it before as a recommended thing to do, and it seems incredibly risky / complex to review. If we're going to do this, why have a lockfile at all? I'd much rather see PRs to bump individual transitive dependencies that we know need updating for a specific reason, and beyond that just let them naturally update as direct dependencies require. |
I think enough of us have said -1 to this PR that it shouldn't land, and we should continue discussion on https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1744401326173889. Sorry for the noise, everyone! |
Description
This is a chore re-sync of the lockfile. It's been a while since this file was re-generated, and it's important (IMO) to do it every once in a while.
All tests pass, storybook looks fine, and nothing crashes AFAICT on Chrome + Safari.
Validation
Nothing should change, and no tests should fail
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.