NSFS | content dir versioning LIST and tagging operations #8814
Conversation
nadavMiz
force-pushed
the
directory-object-list-operation
branch
6 times, most recently
from
ccbf9f6 to
573c2d1
Compare
| const fs_context = this.prepare_fs_context(object_sdk); | ||
| const file_path = await this._find_version_path(fs_context, params, true); |
There was a problem hiding this comment.
have you checked that this change is compatible to S3? especially when versioning is suspended, delete tagging from the version id file is expected per the protocol?
There was a problem hiding this comment.
there shouldn't be a difference between enabled and suspended mode. but I will validate this. I will also check what happens if we are in disabled mode and have version as a parameter
There was a problem hiding this comment.
yes. it works in the same in suspended mode. its worth mentioning that for both enabled and suspended mode, it setobjecttagging failed without version-id with the following error:
An error occurred (MethodNotAllowed) when calling the PutObjectTagging operation: The specified method is not allowed against this resource.
I'll continue investigating this, but this seems more like a bucket policy quirk then anything else (there is nothing about it in the documentation for getObjectTagging)
anyway its out of scope for this PR
|
@nadavMiz please add a link in the description to all the content directory PRs the original issue, I think it's 8531 |
nadavMiz
force-pushed
the
directory-object-list-operation
branch
2 times, most recently
from
629a556 to
b59fbb2
Compare
nadavMiz
force-pushed
the
directory-object-list-operation
branch
from
b59fbb2 to
e20a6ac
Compare
nadavMiz
force-pushed
the
directory-object-list-operation
branch
2 times, most recently
from
b738cb5 to
b182aec
Compare
src/sdk/namespace_fs.js
Outdated
| if (this._is_hidden_version_path(obj_info.key)) { | ||
| obj_info.key = path.normalize(obj_info.key.replace(HIDDEN_VERSIONS_PATH + '/', '')); | ||
| obj_info.key = _get_filename(obj_info.key); | ||
| set_latest_delete_marker(obj_info); |
There was a problem hiding this comment.
should set_latest_delete_marker() function be a part of a function called format_key_name() ?
There was a problem hiding this comment.
right, it shouldn't. also putting it inside _is_hidden_version_path doesn't really add anything. I moved it outside
| const fs_context = this.prepare_fs_context(object_sdk); | ||
| const file_path = await this._find_version_path(fs_context, params, true); |
nadavMiz
force-pushed
the
directory-object-list-operation
branch
4 times, most recently
from
1e975b3 to
67da1c7
Compare
…ing operations Signed-off-by: nadav mizrahi <[email protected]>
nadavMiz
force-pushed
the
directory-object-list-operation
branch
from
67da1c7 to
08fe0a3
Compare
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Content-dir versioning issue: #8531
continuation of #8773
####GAPS
Testing Instructions: