-
Notifications
You must be signed in to change notification settings - Fork 83
Added required validations in lifecycle rules #8914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
49c13e5
to
7280645
Compare
7280645
to
7ee8bd9
Compare
a7bd587
to
182699d
Compare
s3tests_boto3/functional/test_s3.py::test_lifecycle_expiration_tags1 same test is failing for both the CI due to |
@achouhan09 we are S3 compatible, therefore we should do what AWS is allowing. Please run the same check on AWS and let us know if the bug is on ceph tests or on our side
|
here in ceph-s3 tests they are applying a lifecycle rule without |
@achouhan09 and when adding the And it works? |
182699d
to
cb95060
Compare
cb95060
to
eab26dd
Compare
@romayalon yes its working with I cannot merge this PR without the ceph-s3 test fixes or we need to make temporary changes in our code and remove that test. wdyt? |
eab26dd
to
f813b80
Compare
f813b80
to
6e5b72a
Compare
…on and AboutIncompleteMultipartUpload 2. Added tests for the above validations Signed-off-by: Aayush Chouhan <[email protected]>
Signed-off-by: Aayush Chouhan <[email protected]>
6e5b72a
to
de96bdd
Compare
Describe the Problem
The following validations are missing from PutBucketLifecycleConfiguration:
Date
must be exactly 00:00:00 UTC, or AWS rejects it.Tags
orObjectSizeGreaterThan/LessThan
.Days/Date
cannot be used withExpiredObjectDeleteMarker
.Filters
to be inside anAnd
block.Explain the Changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
make run-single-test-postgres testname=lifecycle_index.js