NC | lifecycle | add newer noncurrent versions rule #8949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavMiz
force-pushed
the
lifecycle-noncurrent-versions
branch
from
80e457f to
4e8cce9
Compare
nadavMiz
force-pushed
the
lifecycle-noncurrent-versions
branch
from
4e8cce9 to
d0812c8
Compare
2 tasks
nadavMiz
force-pushed
the
lifecycle-noncurrent-versions
branch
2 times, most recently
from
91b22d3 to
a7a2dd8
Compare
romayalon
reviewed
Apr 10, 2025
nadavMiz
force-pushed
the
lifecycle-noncurrent-versions
branch
from
a7a2dd8 to
c4d2e56
Compare
nadavMiz
force-pushed
the
lifecycle-noncurrent-versions
branch
2 times, most recently
from
42ee938 to
995cba6
Compare
nadavMiz
force-pushed
the
lifecycle-noncurrent-versions
branch
from
995cba6 to
0cd81c4
Compare
romayalon
approved these changes
Apr 21, 2025
| } else { | ||
| rule_state.is_finished = true; | ||
| } | ||
| const bucket_state = this.lifecycle_run_status.buckets_statuses[bucket_json.name].state; |
There was a problem hiding this comment.
not necessarily on this PR if you don't want, I think we can move the accumulation of num_processed_objects to update_status(), can you add it as a gap?
| * @returns {Promise<Object[]>} | ||
| */ | ||
| async get_candidates_by_expiration_rule_posix(lifecycle_rule, bucket_json, object_sdk) { | ||
| const rule_state = this.lifecycle_run_status.buckets_statuses[bucket_json.name].rules_statuses[lifecycle_rule.id].state.expire; |
There was a problem hiding this comment.
seems like my GPFS code is not aligned with the state.expire change,
let's talk on our meeting today what we need to do there
Signed-off-by: nadav mizrahi <[email protected]>
nadavMiz
force-pushed
the
lifecycle-noncurrent-versions
branch
from
0cd81c4 to
800a847
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Problem
add lifecycle rule to delete noncurrent objects based on number of newer version. save progress in state struck to enable work in batches. change the state structure to enable working on both expire and noncurrent actions in the same rule
Explain the Changes
load_versions_listandload_object_listGaps
Testing Instructions:
sudo npx jest test_nc_lifecycle_cli