Migrate to Vite + Vitest #774

MTRNord · 2024-09-06T16:20:53Z

✔️ Checklist

A changeset describing the change and affected packages (more info).
Added or updated documentation.
Tests for new functionality and regression tests for bug fixes.
Screenshots or videos attached (for UI changes).
All your commits have a Signed-off-by line in the message (more info).

changeset-bot · 2024-09-06T16:20:56Z

🦋 Changeset detected

Latest commit: d130fa0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@matrix-widget-toolkit/testing	Major
@matrix-widget-toolkit/react	Patch
@matrix-widget-toolkit/api	Patch
@matrix-widget-toolkit/mui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

MTRNord · 2024-09-06T18:39:27Z

fb94ea6 exists due to dequelabs/axe-core#4458

.changeset/eighty-taxis-repair.md

MTRNord · 2024-09-06T20:03:14Z

For discussion: We could replace rollup too with https://vitejs.dev/guide/build.html#library-mode

HarHarLinks · 2024-09-17T08:29:30Z

is there a reasonable way to sync certain configs across projects? e.g. I see parts of eslint config changed here to include the same options as standalone (but also more) and also options are in a different order.

MTRNord · 2024-09-17T09:37:49Z

is there a reasonable way to sync certain configs across projects? e.g. I see parts of eslint config changed here to include the same options as standalone (but also more) and also options are in a different order.

Not sure for vite/vitest, but for eslint we can make a ruleset and use that just like we do with other eslint plugins. There is already a ticket for this.

HarHarLinks · 2024-09-18T13:25:50Z

Did/can you check if any of the warnings produces by yarn check are relevant to this PR?

weeman1337 · 2024-09-24T08:52:34Z

is there a reasonable way to sync certain configs across projects? e.g. I see parts of eslint config changed here to include the same options as standalone (but also more) and also options are in a different order.

see NEO-689

.gitignore

Outline the vitest migration Add changesets Fix typos Fix missing dependencies Remove obsolete jest config Remove more old references to jest Use our own more simple vitest-axe extension Adjust the i18next-parser.config.js Ensure the coverage dependency is made a dependency and ensure we are not running in commonjs mode Use the correct axe import Fix vite config for the example widget and the dedup of it. Also fix the exports in the package jsons Ensure we run cleanup from @testing-library/react after each test to have a clean state Exclude the build and lib folders to prevent falsely detected tests Run check-api-report to update the testing library Ensure we don't mix act from different dependencies and just always use the one from react Fixup review items and update docs as needed Signed-off-by: MTRNord <[email protected]>

Signed-off-by: Michael Weimann <[email protected]>

README.md

HarHarLinks

please update containers/widget-server/README.md regarding CRA. there is another mention in the ADRs which I think we can keep.

example-widget-mui/index.html

Signed-off-by: Michael Weimann <[email protected]>

weeman1337 · 2024-09-25T07:45:25Z

should we change the default ports for vite in the neotoolsuite so the different things don't collide (or autoresolve the collision, mixing up the order every time)?

Vite should resolve port conflicts. You get an URL in the shell when running it. Will double-check anyway.

Can confirm. Vite looks for the next free port and prints it to the shell.

That isn't the point, I said I do not want to autoresolve the conflicts: I want to yarn dev the mui demo widget and add it to my test room at $port and if i tomorrow start the neoboard widget first and the demo widget second, the demo widget should still appear on $port so it is in the room i added it to and i don't need to set everything up from scratch again.

Ports for the example widget and preview are now: 5173 (http) and 5174 (https).

Lets use the next ports for neoboard etc. then.

If preview and dev should be different ports, leave a comment. I don't have a strong opinion on this.

Signed-off-by: Michael Weimann <[email protected]>

weeman1337 · 2024-09-25T07:52:52Z

please update containers/widget-server/README.md regarding CRA. there is another mention in the ADRs which I think we can keep.

done

Signed-off-by: Michael Weimann <[email protected]>

example-widget-mui/vite.config.ts

containers/widget-server/README.md

Signed-off-by: Michael Weimann <[email protected]>

MTRNord force-pushed the nic/feat/NEO-681 branch 3 times, most recently from 6870309 to b8f226e Compare September 6, 2024 18:28

MTRNord force-pushed the nic/feat/NEO-681 branch from f33a7b0 to 9d12a98 Compare September 6, 2024 19:27

MTRNord commented Sep 6, 2024

View reviewed changes

.changeset/eighty-taxis-repair.md Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

MTRNord marked this pull request as ready for review September 6, 2024 19:59

MTRNord requested a review from a team September 6, 2024 19:59

MTRNord mentioned this pull request Sep 9, 2024

Add eslint-plugin-react-hooks #773

Merged

5 tasks

This comment was marked as resolved.

Sign in to view

MTRNord force-pushed the nic/feat/NEO-681 branch 3 times, most recently from 92795de to 6cf1177 Compare September 23, 2024 19:47

weeman1337 changed the title ~~Migrate to vitejs + vitest~~ Migrate to Vite + Vitest Sep 24, 2024

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

weeman1337 reviewed Sep 24, 2024

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

MTRNord and others added 2 commits September 24, 2024 14:16

Remove personal git ignores

976634b

Signed-off-by: Michael Weimann <[email protected]>

Fix example Dockerfile

9d93427

Signed-off-by: Michael Weimann <[email protected]>

weeman1337 force-pushed the nic/feat/NEO-681 branch from 3878063 to 9d93427 Compare September 24, 2024 12:31

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

HarHarLinks requested changes Sep 24, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

HarHarLinks requested changes Sep 24, 2024

View reviewed changes

example-widget-mui/index.html Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

weeman1337 added 2 commits September 25, 2024 09:41

Use fixed ports for the example widget

75bd8ef

Signed-off-by: Michael Weimann <[email protected]>

Fix yarn commands and doc

0432268

Signed-off-by: Michael Weimann <[email protected]>

Remove CRA specific documentation

5f2421b

Signed-off-by: Michael Weimann <[email protected]>

weeman1337 dismissed their stale review via 5f2421b September 25, 2024 07:52

weeman1337 requested review from HarHarLinks and weeman1337 September 25, 2024 08:15

weeman1337 previously approved these changes Sep 25, 2024

View reviewed changes

Fix widget toolkit example title

1d016bb

Signed-off-by: Michael Weimann <[email protected]>

weeman1337 dismissed their stale review via 1d016bb September 25, 2024 13:07

HarHarLinks reviewed Sep 25, 2024

View reviewed changes

example-widget-mui/vite.config.ts Outdated Show resolved Hide resolved

HarHarLinks reviewed Sep 25, 2024

View reviewed changes

containers/widget-server/README.md Outdated Show resolved Hide resolved

HarHarLinks mentioned this pull request Sep 25, 2024

Update READMEs #790

Merged

5 tasks

weeman1337 added 2 commits September 26, 2024 13:24

Set preview port

f66f7c4

Signed-off-by: Michael Weimann <[email protected]>

Remove mention of webpack

d130fa0

Signed-off-by: Michael Weimann <[email protected]>

weeman1337 requested review from weeman1337 and HarHarLinks September 26, 2024 11:27

weeman1337 approved these changes Sep 26, 2024

View reviewed changes

HarHarLinks approved these changes Sep 26, 2024

View reviewed changes

weeman1337 merged commit f00e7cf into main Sep 26, 2024
4 checks passed

weeman1337 deleted the nic/feat/NEO-681 branch September 26, 2024 11:34

mgcm mentioned this pull request Feb 20, 2025

The docs dont mention that window.process.env has to be set for the toolkit to work #754

Closed

Migrate to Vite + Vitest #774

Migrate to Vite + Vitest #774

Uh oh!

Conversation

MTRNord commented Sep 6, 2024 • edited by HarHarLinks Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

MTRNord commented Sep 6, 2024

Uh oh!

Uh oh!

This comment was marked as resolved.

MTRNord commented Sep 6, 2024

Uh oh!

HarHarLinks commented Sep 17, 2024

Uh oh!

MTRNord commented Sep 17, 2024

Uh oh!

This comment was marked as resolved.

Uh oh!

HarHarLinks commented Sep 18, 2024

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

weeman1337 commented Sep 24, 2024

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

Uh oh!

HarHarLinks left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as resolved.

weeman1337 commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weeman1337 commented Sep 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MTRNord commented Sep 6, 2024 •

edited by HarHarLinks

Loading

changeset-bot bot commented Sep 6, 2024 •

edited

Loading

HarHarLinks left a comment •

edited

Loading

weeman1337 commented Sep 25, 2024 •

edited

Loading