Skip to content

fix: join the docker volumes with \n instead of , #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2022

Conversation

kayman-mk
Copy link
Collaborator

@kayman-mk kayman-mk commented May 9, 2022

Description

Join the Docker tmpfs volumes in the runner-config.tpl with a newline character instead of ,. This gives the correct syntax as explained in the mentioned issue.

[runners.docker.services_tmpfs]
"/var/lib/mysql/" = "rw,noexec","/var/lib/postgresql/data" = "rw,noexec"

Closes #479

Migrations required

No

Verification

Checked the plan for multiple volumes.

@npalm npalm merged commit f9de728 into cattle-ops:develop May 16, 2022
semantic-releaser bot pushed a commit that referenced this pull request May 16, 2022
## [4.42.0](4.41.1...4.42.0) (2022-05-16)

### Features

* Add option to specify prometheus metrics listen address [#478](#478) ([d441e27](d441e27))
* support runner AuthenticationType configuration ([7d3617e](7d3617e))

### Bug Fixes

* join the volumes with \n instead of , ([#480](#480)) ([f9de728](f9de728))
@semantic-releaser
Copy link
Contributor

🎉 This PR is included in version 4.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple tmpfs volume entries doesn't work
2 participants