Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support volume type configuration #579

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

ryancormack
Copy link
Contributor

Description

Allow setting a configurable parameter to set the EBS volume type on the instances spawned to run jobs. This defaults to gp2, and is not required

Fixes #578

A few sentences describing the overall goals of the pull request's commits.

Migrations required

NO

Verification

Please mention the examples you have verified.

Allow setting a configurable parameter to set the EBS volume type on the instances spawned to run jobs. This defaults to gp2, and is not required
Copy link
Collaborator

@kayman-mk kayman-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good!

@npalm npalm changed the title Enable runners volume type config feat: Support volume type configuration Nov 27, 2022
@npalm npalm merged commit b7dd834 into cattle-ops:develop Nov 27, 2022
semantic-releaser bot pushed a commit that referenced this pull request Nov 27, 2022
## [5.5.0](5.4.1...5.5.0) (2022-11-27)

### Features

* Support volume type configuration ([#579](#579)) ([b7dd834](b7dd834))

### Bug Fixes

* Compress (zip) user_data to avoid max size ([#565](#565)) ([64b8594](64b8594))
* ensure a complete `config.toml` before starting the GitLab Agent ([#574](#574)) ([e32f3bc](e32f3bc))
* Use runners_pull_policies to set pull_policy instead of allowed_pull_policies ([#557](#557)) ([a67b87b](a67b87b))
@semantic-releaser
Copy link
Contributor

🎉 This PR is included in version 5.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

npalm pushed a commit to npalm/test-repo that referenced this pull request Dec 8, 2022
## [5.5.0](cattle-ops/terraform-aws-gitlab-runner@5.4.1...5.5.0) (2022-11-27)

### Features

* Support volume type configuration ([#579](cattle-ops/terraform-aws-gitlab-runner#579)) ([b7dd834](cattle-ops/terraform-aws-gitlab-runner@b7dd834))

### Bug Fixes

* Compress (zip) user_data to avoid max size ([#565](cattle-ops/terraform-aws-gitlab-runner#565)) ([64b8594](cattle-ops/terraform-aws-gitlab-runner@64b8594))
* ensure a complete `config.toml` before starting the GitLab Agent ([#574](cattle-ops/terraform-aws-gitlab-runner#574)) ([e32f3bc](cattle-ops/terraform-aws-gitlab-runner@e32f3bc))
* Use runners_pull_policies to set pull_policy instead of allowed_pull_policies ([#557](cattle-ops/terraform-aws-gitlab-runner#557)) ([a67b87b](cattle-ops/terraform-aws-gitlab-runner@a67b87b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Enable runner instance volume type choices
3 participants