Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Incorporate worker thread id in temporary filename #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fixtures/thread-id-test-worker.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'use strict'

require('worker_threads').parentPort.postMessage(require('../thread-id'))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried inlining this fixture into the tests using the eval option when constructing the Worker, but this require needs to be resolved from somewhere. Couldn't find a way to set that if it's possible.

3 changes: 2 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ var util = require('util')
var MurmurHash3 = require('imurmurhash')
var iferr = require('iferr')
var crypto = require('crypto')
var threadId = require('./thread-id')

function murmurhex () {
var hash = MurmurHash3('')
Expand All @@ -15,7 +16,7 @@ function murmurhex () {

var invocations = 0
function getTmpname (filename) {
return filename + '.' + murmurhex(__filename, process.pid, ++invocations)
return filename + '.' + murmurhex(__filename, process.pid, threadId, ++invocations)
}

var setImmediate = global.setImmediate || setTimeout
Expand Down
30 changes: 30 additions & 0 deletions test/thread-id.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'use strict'

var test = require('tap').test
var path = require('path')
var threadId = require('../thread-id')

var Worker
try {
Worker = require('worker_threads').Worker
} catch (e) {}

test('the main process has thread -1', function (t) {
t.equal(threadId, -1)
t.end()
})

if (Worker != null) {
test('workers have positive integer threadIds', function (t) {
t.plan(2)

var w1 = new Worker(path.join(__dirname, '../fixtures/thread-id-test-worker.js'))
w1.once('message', function (message) {
t.equal(message, 1)
})
var w2 = new Worker(path.join(__dirname, '../fixtures/thread-id-test-worker.js'))
w2.once('message', function (message) {
t.equal(message, 2)
})
})
}
16 changes: 16 additions & 0 deletions thread-id.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict'

var threadId
try {
var Worker = require('worker_threads')
if (Worker.isMainThread) {
threadId = -1
} else {
threadId = Worker.threadId
}
} catch (e) {
// no worker support
threadId = -1
}

module.exports = threadId