Skip to content

bluetooth: samples: Save and restore local steps in RAS server callback #22467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

olivier-le-sage
Copy link
Contributor

Because of the way connection callbacks work, and because bt_le_cs_step_data_parse() consumes the data in the buffer, any user callbacks called after this module's would end up losing access to the step data.

To avoid this problem, we can do a simple save and restore when parsing.

Because of the way connection callbacks work, and because
bt_le_cs_step_data_parse() consumes the data in the buffer, any user
callbacks called after this module's would end up losing access to the
step data.

To avoid this problem, we can do a simple save and restore when parsing.

Signed-off-by: Olivier Lesage <[email protected]>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 22, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 22, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 803e71ec228572e9b33529d0c0df1808e47a64c3

more details

sdk-nrf:

PR head: 803e71ec228572e9b33529d0c0df1808e47a64c3
merge base: f608bd3999c54bb65bd41cb36b43fdcb7c1111e6
target head (main): 2727f2f3a56ecdae669b9f898b7ae913075f2a32
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
subsys
│  ├── bluetooth
│  │  ├── services
│  │  │  ├── ras
│  │  │  │  ├── rrsp
│  │  │  │  │  │ ras_rd_buffer.c

Outputs:

Toolchain

Version: 1d2c5d0ab5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:1d2c5d0ab5_e85602c25f

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 20
  • ✅ Integration tests
    • ✅ desktop52_verification
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-sdk-find-my
Disabled integration tests
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@olivier-le-sage olivier-le-sage marked this pull request as ready for review May 22, 2025 17:00
@olivier-le-sage olivier-le-sage requested a review from a team as a code owner May 22, 2025 17:00
@ivaniushkov ivaniushkov self-requested a review May 23, 2025 08:16
@anangl anangl merged commit 64c7bf3 into nrfconnect:main May 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants