[nrf noup] scripts: west_commands: runners: nrfjprog: bring --snr back #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch partially reverts 2cee5ff. nRF VScode extension implemented support for the new option, `--dev-id`, however, it relied on deprecated code paths to detect wether Zephyr supported `--dev-id` or not. The extension has been updated to fix this issue, so this patch can be safely removed once a new release of the extension gets deployed. In the mean time, it will allow people working on `main` to not experience any issues. Signed-off-by: Gerard Marull-Paretas <[email protected]>
|
A new VS Code release has now been published on the marketplace: https://nrfconnect.github.io/vscode-nrf-connect/release_notes/connect/2022.11.140.html#fixes-in-2023144 Users will have to restart VS Code to get it, but IMO, we can close this PR, as this is no longer an issue for VS Code. |
Great, thanks for the update. Will close then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch partially reverts 2cee5ff.
nRF VScode extension implemented support for the new option,
--dev-id, however, it relied on deprecated code paths to detect wether Zephyr supported--dev-idor not. The extension has been updated to fix this issue, so this patch can be safely removed once a new release of the extension gets deployed. In the mean time, it will allow people working onmainto not experience any issues.Signed-off-by: Gerard Marull-Paretas [email protected]