This repository was archived by the owner on Jun 10, 2020. It is now read-only.
TST: also run the code in "pass" #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the failures are expected in that they are places where the stubs are not yet good enough to catch the issue, but some of these might merit issues being opened. Hm and CI is failing on Python 3.7 only; that's interesting. |
|
Ok, on 3.7 CI was running NumPy 1.14.2 which is what was causing the failures. I went ahead and bumped the minimum version to 1.16.0; that still goes 3 releases back (soon to be 4), so should be fine I think. |
It seems fair that the code in pass should also run; i.e. that directory shouldn't contain mypy false positives. Add a test that runs the modules in that directory and fix the resulting runtime errors.
|
Fixes for some of the things addressed in this PR have been merged now, so rebased to include them. |
|
Merged, thanks @person142 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems fair that the code in pass should also run; i.e. that
directory shouldn't contain mypy false positives. Add a test that runs
the modules in that directory and fix the resulting runtime errors.