Improve testing in CI #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add artifact upload to action, ensure runs even if build fails - Only upload tracebacks in gh artifact. - Update deps in environment.yml and requirements.txt
|
LGTM, thanks @rossbar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the CI for the project by:
conda-based workflowThe first bullet will ensure that both
condaandpipbased workflows are working as expected, and help prevent the dependency specifications from getting out-of-sync.In principle it'd be great to add windows to the CI as well, but that's currently not possible due to the
gym/atari-pyissue. Once that's solved it should be straightforward to add them.